Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump required R version to 4.0 #515

Merged
merged 6 commits into from
Dec 14, 2024
Merged

Conversation

etiennebacher
Copy link
Member

Necessary due to recent update of evaluate that has this requirement.

Close #500

@strengejacke
Copy link
Member

Where do we need that package?

@etiennebacher
Copy link
Member Author

Let's see if we follow this: easystats/easystats#401 (comment)

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.20%. Comparing base (81dd0e0) to head (53952a0).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #515      +/-   ##
==========================================
+ Coverage   91.14%   91.20%   +0.05%     
==========================================
  Files          76       76              
  Lines        6045     6086      +41     
==========================================
+ Hits         5510     5551      +41     
  Misses        535      535              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@strengejacke
Copy link
Member

I think this is safe to do. This means that future updates from parameters will require minimum R4.0, too, when I update package dependencies. But: (foreign) packages that import either datawizard or parameters either also depend on R 4.0.0 or higher, or already import other packages that reqire R 4.0.0 or higher (e.g. package dotwhisker imports gtable, wich requires R 4.0). And furthermore, it's still possible to run all these packages in R 3.6 with older package versions. So, no serious concerns here, I think.

@etiennebacher
Copy link
Member Author

Went back to the original discussion on the version policy, seems like the version policy is outdated because we can't test on 3.6 anymore?
https://easystats.github.io/easystats/articles/version_policy.html

@strengejacke
Copy link
Member

I leave it to you to decide which R version should be required. It's always possible to run older package versions on R 3.6.

@etiennebacher
Copy link
Member Author

Alright let's go with 4.0. We don't test on lower versions and it's available since May 2020.

@etiennebacher etiennebacher merged commit 0faf924 into main Dec 14, 2024
21 of 22 checks passed
@etiennebacher etiennebacher deleted the bump-version-requirement branch December 14, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests are failing on R 3.6
2 participants